-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add first notices for svom/eclairs #126
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
498bb03
draft n1e notices
timroland 64c02a1
Update gcn/notices/svom/eclairs/slewing.example.json
b6ba5bd
Update gcn/notices/svom/eclairs/wakeup.example.json
0e5f24b
add grm alert notice
timroland 1784ef5
Fix merging conflict
timroland 9a4e642
modify grm fields as it is not an imager
timroland 2c1c24b
Merge branch 'nasa-gcn:main' into main
fa0a34e
Update "triggered GRDs" field
3bc4290
Merge branch 'nasa-gcn:main' into main
42889c7
adapt grm notice example to the schema change
timroland 0fb4ea1
Merge branch 'nasa-gcn:main' into main
timroland d18745f
update trigger schema and examples
timroland 9930540
Merge branch 'nasa-gcn:main' into main
timroland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/svom/trigger.schema.json", | ||
| "instrument": "ECLAIRs", | ||
| "alert_datetime": "2024-02-22T08:51:55", | ||
| "alert_tense": "test", | ||
| "alert_type": "initial", | ||
| "id": ["sb24022203"], | ||
| "event_name": ["M1"], | ||
| "trigger_time": "2024-02-22T08:51:31.320000", | ||
| "ra": 143.2478, | ||
| "dec": -68.0289, | ||
| "ra_dec_error": 0.1, | ||
| "image_snr": 25.67, | ||
| "image_duration": 0.0, | ||
| "image_energy_range": [4, 20], | ||
| "trigger_type": "rate", | ||
| "slew_status": "not_requested" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/svom/trigger.schema.json", | ||
| "instrument": "ECLAIRs", | ||
| "alert_datetime": "2024-02-22T08:51:55", | ||
| "alert_tense": "test", | ||
| "alert_type": "update", | ||
| "id": ["sb24022203"], | ||
| "trigger_time": "2024-02-22T08:51:31.320000", | ||
| "ra": 143.2478, | ||
| "dec": -68.0289, | ||
| "ra_dec_error": 0.1, | ||
| "image_snr": 25.67, | ||
| "image_duration": 0.0, | ||
| "image_energy_range": [4, 20], | ||
| "trigger_type": "rate", | ||
| "slew_status": "rejected" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/svom/trigger.schema.json", | ||
| "instrument": "ECLAIRs", | ||
| "alert_datetime": "2024-02-22T08:51:55", | ||
| "alert_tense": "test", | ||
| "alert_type": "update", | ||
| "id": ["sb24022203"], | ||
| "trigger_time": "2024-02-22T08:51:31.320000", | ||
| "ra": 143.2478, | ||
| "dec": -68.0289, | ||
| "ra_dec_error": 0.1, | ||
| "image_snr": 25.67, | ||
| "image_duration": 0.0, | ||
| "image_energy_range": [4, 20], | ||
| "trigger_type": "rate", | ||
| "slew_status": "accepted" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/svom/trigger.schema.json", | ||
| "instrument": "ECLAIRs", | ||
| "alert_datetime": "2024-02-22T08:51:55", | ||
| "alert_tense": "test", | ||
| "alert_type": "initial", | ||
| "id": ["sb24022203"], | ||
| "trigger_time": "2024-02-22T08:51:31.320000", | ||
| "ra": 143.2478, | ||
| "dec": -68.0289, | ||
| "ra_dec_error": 0.1, | ||
| "image_snr": 25.67, | ||
| "image_duration": 0.0, | ||
| "image_energy_range": [4, 20], | ||
| "trigger_type": "rate", | ||
| "slew_status": "not_requested" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/svom/trigger.schema.json", | ||
| "instrument": "GRM", | ||
| "alert_datetime": "2024-02-22T08:51:55", | ||
| "alert_tense": "test", | ||
| "alert_type": "initial", | ||
| "id": ["sb24022203"], | ||
| "trigger_time": "2024-02-22T08:51:31.320000", | ||
| "ra": 143.2478, | ||
| "dec": -68.0289, | ||
| "ra_dec_error": 0.1, | ||
| "rate_snr": 25.67, | ||
| "rate_duration": 0.0, | ||
| "rate_energy_range": [15, 550], | ||
| "triggered_GRDs": [true, true, true] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| { | ||
| "$id": "https://gcn.nasa.gov/schema/main/gcn/notices/svom/trigger.schema.json", | ||
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "type": "object", | ||
| "unevaluatedProperties": false, | ||
| "title": "SVOM trigger alerts", | ||
| "description": "ECLAIRs or GRM trigger parameters computed onboard", | ||
| "allOf": [ | ||
| { "$ref": "../core/AdditionalInfo.schema.json" }, | ||
| { "$ref": "../core/Alert.schema.json" }, | ||
| { "$ref": "../core/DateTime.schema.json" }, | ||
| { "$ref": "../core/Event.schema.json" }, | ||
| { "$ref": "../core/Localization.schema.json" }, | ||
| { "$ref": "../core/Reporter.schema.json" }, | ||
| { "$ref": "../core/Statistics.schema.json" }, | ||
| { "$ref": "../core/Pointing.schema.json" }, | ||
| { "$ref": "../core/GeoLocBase.schema.json" } | ||
| ], | ||
| "properties": { | ||
| "$schema": true, | ||
| "slew_status": { | ||
| "enum": ["accepted", "rejected", "not_requested"], | ||
| "description": "Spacecraft slew status" | ||
| }, | ||
| "triggered_GRDs": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "boolean" | ||
| }, | ||
| "minItems": 3, | ||
| "maxItems": 3, | ||
| "description": "In case of a GRM trigger, trigger status the 3 GRDs. Each item correspond to one of the 3 GRDs: true means the GRD triggers, false not" | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @timroland, could you please tell us where you have used the Pointing Schema in examples? I was going through the examples, and all of them have (ra, dec, ra_dec_error), these parameters together should be used for the Localization schema. Is at any place are you using Pointing Schema?