Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointing schema: rename (ra, dec) #146

Merged
merged 3 commits into from
Jun 7, 2024
Merged

pointing schema: rename (ra, dec) #146

merged 3 commits into from
Jun 7, 2024

Conversation

Vidushi-GitHub
Copy link
Member

Description

Rename property (ra, dec) as present in localization schema as well.

Related Issue(s)

#145

@Vidushi-GitHub Vidushi-GitHub requested a review from jracusin May 28, 2024 16:38
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name change is fine, but I think that the pointing schema is underspecified and ill-defined. What frame is this in? ICRS? GCRS? HCRS?

@Vidushi-GitHub
Copy link
Member Author

The name change is fine, but I think that the pointing schema is underspecified and ill-defined. What frame is this in? ICRS? GCRS? HCRS?

Thank you, I was also in similar thought, while comparing with Localization Schema.

@Vidushi-GitHub Vidushi-GitHub requested a review from lpsinger May 31, 2024 16:26
@Vidushi-GitHub Vidushi-GitHub requested review from jracusin and lpsinger and removed request for lpsinger and jracusin June 6, 2024 16:22
@lpsinger lpsinger merged commit 4784a02 into main Jun 7, 2024
4 checks passed
@lpsinger lpsinger deleted the Core/Pointing branch June 7, 2024 16:35
@lpsinger
Copy link
Member

lpsinger commented Jun 7, 2024

@Vidushi-GitHub, next time please remember to create branches for PRs on your own fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants