Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming fixes #147

Closed
wants to merge 2 commits into from
Closed

Naming fixes #147

wants to merge 2 commits into from

Conversation

dakota002
Copy link
Contributor

Naming fixes for example files

@Vidushi-GitHub
Copy link
Member

Vidushi-GitHub commented May 31, 2024

We want to keep the convention as mentioned: https://gcn.nasa.gov/docs/notices/schema.
Thus it should be lower-case instead.

"Mission name should be lowercase and the schema name should be snake_case. Each file corresponds to a Kafka topic named gcn.notices.mission.schema_name."

@Vidushi-GitHub
Copy link
Member

I have separated these modifications into two different PRs,
as both are for different teams.

Please see:
Merged: #148
In Review: https://github.com/nasa-gcn/gcn-schema/pull/149/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants