Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for snake_case consistency #151

Closed
wants to merge 1 commit into from

Conversation

Vidushi-GitHub
Copy link
Member

@Vidushi-GitHub Vidushi-GitHub commented Jun 7, 2024

Description

Change in mission schema name "Capital" to "Lower case".
It's getting validated for $schema properties.

@lpsinger
Copy link
Member

lpsinger commented Jun 7, 2024

Good catch, @Vidushi-GitHub. Before we merge this, I'd like to make sure that our validation script catches case mismatches in $ref and $schema fields.

@lpsinger
Copy link
Member

lpsinger commented Jun 7, 2024

OK, our validation script is case sensitive. No problem there.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but we need someone from BurstCube to be aware of the change. Please find and add an appropriate BurstCube team member as a reviewer.

@Vidushi-GitHub
Copy link
Member Author

This one is Glowbug, they aren't active. @jracusin What should be done?

@Vidushi-GitHub Vidushi-GitHub requested a review from jracusin June 7, 2024 18:47
@lpsinger
Copy link
Member

lpsinger commented Jun 7, 2024

This one is Glowbug, they aren't active. @jracusin What should be done?

Sorry, of course I meant Glowbug. Is that Boyan?

@Vidushi-GitHub
Copy link
Member Author

This one is Glowbug, they aren't active. @jracusin What should be done?

Sorry, of course I meant Glowbug. Is that Boyan?

Yes, Boyan created this one.

@lpsinger lpsinger requested a review from shb46 June 7, 2024 18:53
@lpsinger
Copy link
Member

lpsinger commented Jun 7, 2024

@shb46, would you please review this?

@Vidushi-GitHub
Copy link
Member Author

Vidushi-GitHub commented Nov 18, 2024

@shb46 although you aren't working on this anymore.
But because of our schema policy, we need producers' approval before merging the mission schema.

I am just closing the old PR, could you please approve (if looks fine) this?

@shb46
Copy link
Contributor

shb46 commented Nov 18, 2024

@Vidushi-GitHub: Thanks for fixing the typo.

@shb46 shb46 closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants