-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRB Schema for the CHIME Telescope #217
Open
tabbott36
wants to merge
15
commits into
nasa-gcn:main
Choose a base branch
from
tabbott36:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
468a613
feat(gcn/notices/chime): Added some example jsons and nearly finished…
tabbott36 8ce8bd5
feat(chime/frb.schema.json): final touches on the FRB schema "propert…
tabbott36 f24d367
fix(npm): Fixed npm checks
tabbott36 2ed0008
4.2.0
tabbott36 75cd2af
Back to development
tabbott36 9037eda
Update gcn/notices/chime/frb.schema.json
tabbott36 a36a7b4
Update gcn/notices/chime/detection.example.json
tabbott36 7a3246a
Update gcn/notices/chime/retraction.example.json
tabbott36 b970e05
Update gcn/notices/chime/subsequent.example.json
tabbott36 bdcf2d8
Update gcn/notices/chime/update.example.json
tabbott36 fb8a56b
fix(Versioning): reverted version number to 4.1.0
tabbott36 dd64873
Merge branch 'nasa-gcn:main' into main
tabbott36 42053b9
fix(version): Reverted the version to 4.1.0 using npm
tabbott36 7279d59
fix(gal_el_model-properties): corrected galactic electron density mod…
tabbott36 d2de73c
fix(Data-types): Fixed incorrect data types in FRB schema
tabbott36 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/chime/frb.schema.json", | ||
"alert_type": "detection", | ||
"trigger_time": "2024-09-18T07:19:10.765268Z", | ||
"trigger_time_error": 0.007864319719374001, | ||
"id": "427325191", | ||
tabbott36 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"snr": 12.698559761047363, | ||
"ra": 346.77850859547, | ||
"dec": 12.632485229956252, | ||
"ra_dec_error": [0.503806986334273, 0.598921231135782, 0], | ||
"dm": 279.422607421875, | ||
"dm_error": 0.40437427163124, | ||
"dm_gal_ne_2001_max": 37.78909399600771, | ||
"dm_gal_ymw_2016_max": 29.94072212814185, | ||
"trigger_time_inf_freq": "2024-09-18 07:19:03.518831+00:00", | ||
"trigger_time_inf_freq_error": 0.013108099559195993, | ||
"importance": 0.9871308604784662, | ||
"sampling_time": 0.983, | ||
"bandwidth": 400, | ||
"centre_frequency": 600, | ||
"npol": 2, | ||
"tsys": 50, | ||
"description": "This alert was generated automatically by the CHIME/FRB Real-time Search Pipeline. Please direct comments, questions, and concerns to Thomas Abbott at [email protected]." | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
{ | ||
"$id": "https://gcn.nasa.gov/schema/main/gcn/notices/chime/frb.schema.json", | ||
"$schema": "https://json-schema.org/draft/2020-12/schema", | ||
"title": "CHIME/FRB Alert", | ||
"description": "Fast radio burst alert from the Canadian Hydrogen Intensity Mapping Experiment.", | ||
"type": "object", | ||
"allOf": [ | ||
{ "$ref": "../core/Alert.schema.json" }, | ||
{ "$ref": "../core/Reporter.schema.json" }, | ||
{ "$ref": "../core/Event.schema.json" }, | ||
{ "$ref": "../core/DateTime.schema.json" }, | ||
{ "$ref": "../core/Localization.schema.json" } | ||
], | ||
"properties": { | ||
"known_source": { | ||
"type": "string", | ||
"description": "Transient Name Server name of the known source (if a repeating FRB source)" | ||
}, | ||
"snr": { | ||
"type": "number", | ||
"description": "Signal-to-noise ratio of the burst" | ||
}, | ||
"dm": { | ||
"type": "number", | ||
"description": "Dispersion measure of the burst [pc/cm^3]" | ||
}, | ||
"dm_error": { | ||
"type": "number", | ||
"description": "Error on the dispersion measure [pc/cm^3]" | ||
}, | ||
"dm_gal_ne_2001_max": { "type": "string", "description": "." }, | ||
"dm_gal_ymw_2016_max": { "type": "string", "description": "." }, | ||
"trigger_time_error": { | ||
"type": "number", | ||
"description": "Error on the trigger time [s]" | ||
}, | ||
"trigger_time_inf_freq": { | ||
"type": "string", | ||
"description": "Time of the trigger at infinite frequency [ISO 8601]" | ||
}, | ||
"trigger_time_inf_freq_error": { | ||
"type": "number", | ||
"description": "Error on the trigger time at infinite frequency [s]" | ||
}, | ||
"importance": { | ||
"type": "string", | ||
"description": "A machine learning score from 0-1 separating RFI (0) from an astrophysical signal (1)" | ||
}, | ||
"probability": { | ||
"type": "string", | ||
"description": "A score of known source association probability from poorly associated (0) to confidently associated (1)" | ||
}, | ||
"sampling_time": { | ||
"type": "string", | ||
"description": "The time resolution of the real-time FRB search." | ||
}, | ||
"bandwidth": { | ||
"type": "string", | ||
"description": "The bandwidth of the real-time FRB search." | ||
}, | ||
"centre_frequency": { | ||
"type": "string", | ||
"description": "The centre frequency of the real-time FRB search." | ||
}, | ||
"npol": { | ||
"type": "string", | ||
"description": "The number of polarizations of the real-time FRB search." | ||
}, | ||
"tsys": { | ||
"type": "string", | ||
"description": "The system temperature of the real-time FRB search." | ||
}, | ||
"update_message": { | ||
"type": "string", | ||
"description": "Message to be included in an update alert" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/chime/frb.schema.json", | ||
"alert_type": "retraction", | ||
"id": "FRB 20231013B", | ||
tabbott36 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"trigger_time": "2024-09-18T07:19:10.765268Z", | ||
"trigger_time_error": 0.007864319719374001, | ||
"description": "This alert was generated automatically by human-issued retraction. Please direct comments, questions, and concerns to Thomas Abbott at [email protected]." | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
{ | ||
"$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/chime/frb.schema.json", | ||
"alert_type": "subsequent", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also not a valid value for |
||
"known_source": "FRB 20231013B", | ||
"trigger_time": "2024-09-18T07:19:10.765268Z", | ||
"trigger_time_error": 0.007864319719374001, | ||
"id": "FRB 20240918A", | ||
tabbott36 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"snr": 12.698559761047363, | ||
"ra": 346.77850859547, | ||
"dec": 12.632485229956252, | ||
"ra_dec_error": [0.503806986334273, 0.598921231135782, 0], | ||
"dm": 279.422607421875, | ||
"dm_error": 0.40437427163124, | ||
"dm_gal_ne_2001_max": 37.78909399600771, | ||
"dm_gal_ymw_2016_max": 29.94072212814185, | ||
"trigger_time_inf_freq": "2024-09-18 07:19:03.518831+00:00", | ||
"trigger_time_inf_freq_error": 0.013108099559195993, | ||
"importance": 0.9871308604784662, | ||
"probability": 0.932, | ||
"sampling_time": 0.983, | ||
"bandwidth": 400, | ||
"centre_frequency": 600, | ||
"npol": 2, | ||
"tsys": 50, | ||
"description": "This alert was generated automatically by the CHIME/FRB Real-time Search Pipeline. Please direct comments, questions, and concerns to Thomas Abbott at [email protected]." | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/chime/frb.schema.json", | ||
"alert_type": "update", | ||
"id": "FRB 20231013B", | ||
tabbott36 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"trigger_time": "2024-09-18T07:19:10.765268Z", | ||
"trigger_time_error": 0.007864319719374001, | ||
"update_message": "The dispersion measure of FRB 20231013B has been updated to 221.19271850585938 +/- 0.40437427163124 pc/cm^3.", | ||
"description": "This alert was generated automatically by human-issued retraction. Please direct comments, questions, and concerns to Thomas Abbott at [email protected]." | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a valid option, the allowed values are:
These are defined here https://github.com/nasa-gcn/gcn-schema/blob/main/gcn/notices/core/Alert.schema.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I was hoping to be consistent with existing CHIME/FRB Alert types (see issue 198), but if this is too much trouble, "initial" can replace what we currently call "detection" and "subsquent".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tabbott36 we are working on adding
subsequent
(see #221).However,
initial
will likely remain the same, else we need to take votes from the missions that are already using it.For validation, as
detection
andsubsequent
please add a new property, currentalert_type
is not consistent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sounds good to me. Thanks, Vidushi!