adding synonym getters #2046
Merged
adding synonym getters #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakota002
reviewed
Mar 6, 2024
Comment on lines
25
to
28
| if (!Items.length) | ||
| throw new Response(null, { | ||
| status: 404, | ||
| }) |
There was a problem hiding this comment.
This 404 response might be better moved to whatever routes end up using the function and just returning an empty array if none exist
dakota002
approved these changes
Mar 7, 2024
|
This PR should fix the CI issue: #2047 |
Courey
force-pushed
the
courey/get_synonyms_by_ids_server_only
branch
from
80d8ad3
to
58f6eea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
feat: add gets to synonym server
Description
This PR adds 2 functions. One for getting synonyms by uuid and one for getting or searching synonyms by eventId.
The search utilizes opensearch.
Reviewers
@dakota002 - he can review this pr for style and syntax
Changes
Adds two server functions that are currently unused.
Acceptance Criteria
there are server functions to
Related Issue(s)
Resolves #1935
Testing
syntax and style only. Function is unused and we have not established our db testing methodology yet. A PR will be forthcoming with tests for this and all other functions in the server when that has been decided.