-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JSON section to the Fermi mission page #2650
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2650 +/- ##
=====================================
Coverage 6.21% 6.21%
=====================================
Files 167 167
Lines 4231 4231
Branches 467 467
=====================================
Hits 263 263
Misses 3966 3966
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be behind a feature flag?
@lpsinger: Greetings, I don't understand your question, if it is for me to answer. |
Don't worry, we will suggest the change as feedback. |
Co-authored-by: Vidushi Sharma <[email protected]>
Co-authored-by: Vidushi Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vidushi-GitHub, there are code style errors from Prettier. This seems to happen on several of your PRs. Are you sure that you installed the pre-commit hooks by following the development instructions in our contributing guide?
Yes, I ran npm i. This particular PR is created by @shb46. I was invited as collaborator and has access. |
@shb46 is this finalized from your side? |
@Vidushi-GitHub: Yes. |
|
||
| Type | Contents | Latency | | ||
| ----------------------------- | -------------------------------------- | ---------- | | ||
| `gcn.notices.fermi.gbm.alert` | Localization, Count Rate, Significance | ~5 seconds | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the strict topic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only GBM Alert topic. We don't want "strct" topic(s). Please see discussion in the schema pull request: nasa-gcn/gcn-schema#199 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's for team use only, it wouldn't be streamed, so no point of mentioning to the community.
@Vidushi-GitHub: Thanks! |
Description
Please include a one to two sentence description that summarizes the issue and your solution.
Related Issue(s)
Use Github keywords to link your PR to the related Issue(s). For more information on Github keywords please visit Github's documentation
Example:
Resolves #100
Testing
Describe how you tested this PR. Include step by step instructions for others to test this PR.
Be detailed and include images where appropriate.