Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JSON section to the Fermi mission page #2650

Merged
merged 7 commits into from
Nov 17, 2024
Merged

Conversation

shb46
Copy link
Contributor

@shb46 shb46 commented Oct 28, 2024

Description

Please include a one to two sentence description that summarizes the issue and your solution.

Related Issue(s)

Use Github keywords to link your PR to the related Issue(s). For more information on Github keywords please visit Github's documentation

Example:

Resolves #100

Testing

Describe how you tested this PR. Include step by step instructions for others to test this PR.
Be detailed and include images where appropriate.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.21%. Comparing base (c762233) to head (9acdc84).
Report is 16 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2650   +/-   ##
=====================================
  Coverage   6.21%   6.21%           
=====================================
  Files        167     167           
  Lines       4231    4231           
  Branches     467     467           
=====================================
  Hits         263     263           
  Misses      3966    3966           
  Partials       2       2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be behind a feature flag?

@shb46
Copy link
Contributor Author

shb46 commented Oct 29, 2024

@lpsinger: Greetings, I don't understand your question, if it is for me to answer.

@Vidushi-GitHub
Copy link
Member

Vidushi-GitHub commented Oct 29, 2024

@lpsinger: Greetings, I don't understand your question, if it is for me to answer.

Don't worry, we will suggest the change as feedback.
Feature flag (https://gcn.nasa.gov/docs/contributing/feature-flags) is used to hide the merged content till the announcement/New Notices production.

Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vidushi-GitHub, there are code style errors from Prettier. This seems to happen on several of your PRs. Are you sure that you installed the pre-commit hooks by following the development instructions in our contributing guide?

@Vidushi-GitHub
Copy link
Member

contributing guide

Yes, I ran npm i.
I will re-check and fix with npx prettier.

This particular PR is created by @shb46. I was invited as collaborator and has access.

@Vidushi-GitHub
Copy link
Member

@shb46 is this finalized from your side?

@shb46
Copy link
Contributor Author

shb46 commented Nov 15, 2024

@shb46 is this finalized from your side?

@Vidushi-GitHub: Yes.


| Type | Contents | Latency |
| ----------------------------- | -------------------------------------- | ---------- |
| `gcn.notices.fermi.gbm.alert` | Localization, Count Rate, Significance | ~5 seconds |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the strict topic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only GBM Alert topic. We don't want "strct" topic(s). Please see discussion in the schema pull request: nasa-gcn/gcn-schema#199 (comment)

Copy link
Member

@Vidushi-GitHub Vidushi-GitHub Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's for team use only, it wouldn't be streamed, so no point of mentioning to the community.

@Vidushi-GitHub Vidushi-GitHub merged commit d19a4f6 into nasa-gcn:main Nov 17, 2024
12 checks passed
@shb46
Copy link
Contributor Author

shb46 commented Nov 17, 2024

@Vidushi-GitHub: Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants