CMR-5098: Fix issue with test not deleting revisions from the databas…

…e and remove validation from call to index-collections that prevented removing collection indexes for collections which do not exist in Oracle.

bootstrap-app/src/cmr/bootstrap/api/bulk_index.clj

@@ -25,6 +25,7 @@
   (let [dispatcher (api-util/get-dispatcher context params :index-collection)
         provider-id (get provider-id-collection-map "provider_id")
         collection-id (get provider-id-collection-map "collection_id")
+        _ (service/validate-collection context provider-id collection-id)
         result (service/index-collection
                 context dispatcher provider-id collection-id)]
     {:status 202

bootstrap-app/src/cmr/bootstrap/services/bootstrap_service.clj

@@ -51,7 +51,7 @@
      :bad-request
      [(format "Provider: [%s] does not exist in the system" provider-id)])))
 
-(defn- validate-collection
+(defn validate-collection
    "Validates to be bulk_indexed collection exists in cmr else an exception is thrown."
    [context provider-id collection-id]
    (let [provider (get-provider context provider-id)]
@@ -76,7 +76,6 @@
   ([context dispatcher provider-id collection-id]
    (index-collection context dispatcher provider-id collection-id nil))
   ([context dispatcher provider-id collection-id options]
-   (validate-collection context provider-id collection-id)
    (dispatch/index-collection dispatcher context provider-id collection-id options)))
 
 (defn index-system-concepts

system-int-test/test/cmr/system_int_test/bootstrap/rebalance_collections_test.clj

@@ -50,7 +50,7 @@
        (is (= {:status 400
                :errors ["Provider: [NON_EXIST] does not exist in the system"]}
               (bootstrap/start-rebalance-collection "C1-NON_EXIST" {:synchronous false}))))
-     (testing "Non existent collection"
+     (testing "Non existent collection cannot be moved to a separate index"
        (is (= {:status 400
                :errors ["Collection [C1-PROV1] does not exist."]}
               (bootstrap/start-rebalance-collection "C1-PROV1" {:synchronous false}))))
@@ -481,11 +481,14 @@
 
      (dev-sys-util/clear-caches)
 
-     ; Delete collection and remove the tombstone
+     ;; Delete collection and remove the tombstone
      (ingest/delete-concept deleted-coll-concept)
      (index/wait-until-indexed)
-     (side/eval-form `(tk/advance-time! ~(* (concept-service/days-to-keep-tombstone) 24 3600)))
+     (side/eval-form `(tk/advance-time! ~(* (inc (concept-service/days-to-keep-tombstone)) 24 3600)))
      (is (= 204 (:status (mdb/cleanup-old-revisions))))
+     ;; Verify collection revisions are all removed from the database to make sure test is valid
+     (is (= 404 (:status (search/retrieve-concept (:concept-id deleted-coll) 1))))
+     (is (= 404 (:status (search/retrieve-concept (:concept-id deleted-coll) 2))))
 
      ;; Rebalance to small-collections
      (bootstrap/start-rebalance-collection (:concept-id deleted-coll) {:target "small-collections"})