Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing assertion and functions identifier name correction #182

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

ManzoorAhmedShaikh
Copy link
Contributor

Description

This pull request addresses the #181 issue. There are two bug in the test_print_io.py file related to test functionality and naming conventions.

Fixes

Testing

Verified the tests in 2 different ways:

  • Test the test_print_io_print_sim_header_prints_expected_strings function (which was not testing the functionality at all before) and the other two function where naming are corrected, which aretest_print_io_headers_string_returns_empty_string_when_headers_is_vacant and test_print_io_headers_string_returns_all_headers_in_formatted_string_when_occupied individually by these commands:
python driver.py -t -k "test_print_io_print_sim_header_prints_expected_strings" -v
python driver.py -t -k "test_print_io_headers_string_returns_empty_string_when_headers_is_vacant" -v
python driver.py -t -k "test_print_io_headers_string_returns_all_headers_in_formatted_string_when_occupied" -v
  • Also, test the complete repo with the given command to analyze the coverage:
python driver.py -t
coverage report

Please review the changes and provide feedback. Thank you!😊

@asgibson asgibson linked an issue Feb 19, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (16fe993) to head (8fc7035).
Report is 158 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #182    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           26        31     +5     
  Lines          970      1178   +208     
  Branches       136       167    +31     
==========================================
+ Hits           970      1178   +208     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asgibson asgibson merged commit 4d00241 into nasa:main Feb 21, 2025
5 of 10 checks passed
@asgibson
Copy link
Contributor

Nice work, thank you for the submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix problems in test_print_io
3 participants