Fix the missing assertion and functions identifier name correction #182
+3
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the #181 issue. There are two bug in the
test_print_io.py
file related to test functionality and naming conventions.Fixes
Added the missing assertion to the
test_print_io_print_sim_header_prints_expected_strings
function to ensure proper verification and tested out as well. Here -> https://github.com/nasa/OnAIR/blob/main/test/onair/src/util/test_print_io.py#L119Renamed two test functions to include
header_string
instead offormat_status
for better clarity and accuracy. Here -> https://github.com/nasa/OnAIR/blob/main/test/onair/src/util/test_print_io.py#L577-L609Testing
Verified the tests in 2 different ways:
test_print_io_print_sim_header_prints_expected_strings
function (which was not testing the functionality at all before) and the other two function where naming are corrected, which aretest_print_io_headers_string_returns_empty_string_when_headers_is_vacant
andtest_print_io_headers_string_returns_all_headers_in_formatted_string_when_occupied
individually by these commands:Please review the changes and provide feedback. Thank you!😊