-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-10122: Use EntryId returned by CMR for ID in CMR-STAC #359
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 88.36% 88.33% -0.03%
==========================================
Files 24 24
Lines 1169 1166 -3
Branches 257 258 +1
==========================================
- Hits 1033 1030 -3
Misses 136 136 ☔ View full report in Codecov by Sentry. |
@@ -142,7 +142,7 @@ export type Platform = { | |||
type: string; | |||
shortName: string; | |||
longName: string; | |||
instruments: Instrument[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to fix the issue where if the instrument field was null it was returning an error. It doesn't need comments or anything just pointing it out to reviewers since we chatted about that over DM.
We should add in the test session an assertion to make sure that is fixed
Summary
This PR addresses two issues:
entryID
generation that was previously based onshortName
andversion
from the metadata.instruments
fields were causing errors.Changes
entryID
provided directly from CMR instead of constructing it.instruments
field is null or undefined.Testing
instruments
are null or undefined within platform data.