Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10147: Removing query parameters from self url when generating Child links #362

Merged
merged 9 commits into from
Oct 15, 2024

Conversation

william-valencia
Copy link
Contributor

@william-valencia william-valencia commented Oct 15, 2024

The child links may contain query parameters from a get request. Need to remove these parameters when generating links in CMR-STAC

Before
Screenshot 2024-10-14 at 8 41 25 PM

After
Screenshot 2024-10-14 at 8 41 55 PM

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (57e86a3) to head (9e01d02).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   88.33%   88.34%   +0.01%     
==========================================
  Files          24       24              
  Lines        1166     1167       +1     
  Branches      258      258              
==========================================
+ Hits         1030     1031       +1     
  Misses        136      136              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/routes/catalog.ts Outdated Show resolved Hide resolved
@macrouch
Copy link
Contributor

I think this PR has the wrong title. "Self" links were not modified, only "child" links, right? I was confused by this until I referenced the ticket and saw what was going on.

Need to make sure to update the PR title, and when Squash and Merging the PR make sure the correct message is recorded in the git history

@william-valencia william-valencia changed the title CMR-10147: Removing query parameters from self links CMR-10147: Removing query parameters from self url when generating Child links Oct 15, 2024
@william-valencia
Copy link
Contributor Author

I think this PR has the wrong title. "Self" links were not modified, only "child" links, right? I was confused by this until I referenced the ticket and saw what was going on.

Need to make sure to update the PR title, and when Squash and Merging the PR make sure the correct message is recorded in the git history

Updated the title.

@william-valencia william-valencia merged commit 92565e4 into master Oct 15, 2024
5 checks passed
@william-valencia william-valencia deleted the CMR-10147 branch October 15, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants