-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-10147: Removing query parameters from self url when generating Child links #362
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 88.33% 88.34% +0.01%
==========================================
Files 24 24
Lines 1166 1167 +1
Branches 258 258
==========================================
+ Hits 1030 1031 +1
Misses 136 136 ☔ View full report in Codecov by Sentry. |
I think this PR has the wrong title. "Self" links were not modified, only "child" links, right? I was confused by this until I referenced the ticket and saw what was going on. Need to make sure to update the PR title, and when Squash and Merging the PR make sure the correct message is recorded in the git history |
Updated the title. |
The child links may contain query parameters from a get request. Need to remove these parameters when generating links in CMR-STAC
Before
After