CMR-10146: Making sure validBbox compares numbers and not strings

[william-valencia]

Overview

What is the feature?

CMR-STAC's validBbox function may be passed an array of strings. In this case, the comparison between points does a comparison with strings. When negative numbers are used, comparing negative numbers as strings doesnt work properly.

What is the Solution?

Need to cast the comparison as numbers so numerical comparison is used instead of string comparison.(for negative numbers)

What areas of the application does this impact?

When a bbox array of string is passed in.

Testing

Reproduction steps

• Environment for testing:
• Collection to test with:

Can use the following url to test:
https://cmr.earthdata.nasa.gov/stac/LPCLOUD/search?bbox[0]=-122.09&bbox[1]=39.89&bbox[2]=-122.03&bbox[3]=39.92&datetime=2024-01-01T00:00:00Z/2024-09-24T00:00:00Z&limit=1&collections=HLSL30_2.0

Currently getting an error as follows:
{"errors":["BBOX must be in the form of 'bbox=swLon,swLat,neLon,neLat' with valid latitude and longitude."]}

Attachments

Showing R STAC script not working Showing R STAC script working

Checklist

• I have added automated tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.22%. Comparing base (5d86a25) to head (f452115).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   88.22%   88.22%           
=======================================
  Files          24       24           
  Lines        1180     1180           
  Branches      261      261           
=======================================
  Hits         1041     1041           
  Misses        139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[macrouch]

These lines are covered in CodeCov, so I'd expect a test update to go along with this code change. Because they all still pass maybe the input value to a test somewhere is wrong and it is passing numbers where this was a bug because real values are strings?

If it isn't a bad existing test we should be sure to add a new test that covers when these values are strings. That new test should be pretty easy to add as a unit test on this file, which would be better than trying to track down where in the existing tests this code is called.

[william-valencia]

Adjusted the input values so that unit tests can be written.