Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogma-core: Remove dependency on IfElse. Refs #150. #153

Merged
merged 3 commits into from
Sep 22, 2024

Conversation

ivanperez-keera
Copy link
Member

Replace uses of definitions from IfElse with other functions from base, as prescribed in the solution proposed for #150.

The dependency on IfElse is quite unnecessary: it seems like the only
function we use from that library is awhen :: Monad m => Maybe a -> (a
-> m ()) -> m (), which is a type-specialized version of
Data.Foldable.for_.. Since the latter is in base, we can simplify Ogma
by removing the dependency on IfElse.

This commit replaces uses of awhen with uses of for_.
All uses of functions from IfElse have been replaced with uses of
functions from base. This commit removes the dependency on IfElse from
the ogma-core's cabal file.
@ivanperez-keera
Copy link
Member Author

Change Manager: Verified that:

  • Solution is implemented:
  • Implementation is documented. Details:
    No need for updates to documentation.
  • Change history is clear.
  • Commit messages are clear.
  • Changelogs are updated.
  • Examples are updated. Details:
    No examples affected.
  • Required version bumps are evaluated. Details:
    No update needed; the improvement reduces dependencies.

@ivanperez-keera ivanperez-keera merged commit c4d7386 into nasa:develop Sep 22, 2024
2 checks passed
@ivanperez-keera ivanperez-keera deleted the develop-remove-ifelse branch September 22, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant