Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial stub implementation for DIST-S1 PGE #549

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Initial stub implementation for DIST-S1 PGE #549

merged 6 commits into from
Dec 5, 2024

Conversation

RKuttruff
Copy link
Contributor

Description

  • Implemented PGE classes (pre, post, exec) as child classes of the base PGE classes
  • Added unit test stub and config YAML
  • Added dockerfile + build & test scripts
  • Added runconfig schema file + black files for future templates (MPC, ISO XML)

Affected Issues

Testing

  • Added unit test module for DIST-S1 PGE
  • Added CI script for unit testing
  • DID NOT add CI script for int testing nor supporting QA/comparison scripts for int testing
  • DID NOT update Jenkins pipeline definitions to support this PGE in default builds (I made the changes but held back on committing them)

@RKuttruff RKuttruff added pge.er.01 PGE Engineering Release 01 pge.sprint.r06.03 Sprint 03 for PGE Release 06 pge.r06 PGE Release 06 labels Dec 3, 2024
@RKuttruff RKuttruff self-assigned this Dec 3, 2024
RKuttruff
RKuttruff commented Dec 3, 2024
View reviewed changes
.ci/docker/Dockerfile_dist_s1 Outdated
Comment on lines 57 to 60
&& apt-get update \
&& apt-get install --no-install-recommends -y g++ \
&& apt-get clean \
&& python -m pip install -r ${PGE_DEST_DIR}/opera/requirements.txt \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pip install is failing without g++ installed
We should coordinate with ADT to have a numpy image <2 installed in the SAS so we won't have to worry about rebuilding it here, but it seems the issue is also present in the mgrs install.

collinss-jpl
collinss-jpl requested changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@collinss-jpl collinss-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, mostly just some cut/paste gremlins to take care of

@RKuttruff
Copy link
Contributor Author

@collinss-jpl Addressed findings

@collinss-jpl collinss-jpl merged commit f4df398 into main Dec 5, 2024
2 checks passed
@collinss-jpl collinss-jpl mentioned this pull request Dec 5, 2024
Closed
9 tasks
@RKuttruff RKuttruff deleted the 548_dist-s1-stub branch December 9, 2024 18:43
@kevinmarlis kevinmarlis mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collinss-jpl collinss-jpl collinss-jpl approved these changes

Assignees

@RKuttruff RKuttruff

Labels
pge.er.01 PGE Engineering Release 01 pge.r06 PGE Release 06 pge.sprint.r06.03 Sprint 03 for PGE Release 06
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RKuttruff @collinss-jpl