DIST-S1 Beta 0.0.6 SAS Integration #591
Conversation
- Updated versions - Updated build script - Updated RC Schema - Updated sample & test RCs - Updated validation postprocess step for new file names & output bands that may not be output - Updated unit tests
- Initial version of MPC (still very barebones - need descriptions from ATD (new spec?))
Was accidentally using Mocked DSWx-HLS values since I can't install gdal on my local venv and DSWx-HLS is the default mock
|
Opened as draft PR for any early review/feedback on progress - still more work to do |
DIST-S1 is sourced from RTC-S1 inputs from S1A/C
There was a problem hiding this comment.
Looks great, just a few little adjustments needed. Feel free to merge once addressed, thanks @RKuttruff!
| - /home/ops/input_dir/2024-11-03/OPERA_L2_RTC-S1_T137-292324-IW2_20241103T015919Z_20241103T074936Z_S1A_30_v1.0_VH.tif | ||
| - /home/ops/input_dir/2024-11-03/OPERA_L2_RTC-S1_T137-292325-IW1_20241103T015921Z_20241103T074936Z_S1A_30_v1.0_VH.tif | ||
|
|
||
| - /home/ops/input_dir/2024-09-04/OPERA_L2_RTC-S1_T137-292318-IW1_20240904T015900Z_20240904T150822Z_S1A_30_v1.0_VV.tif |
There was a problem hiding this comment.
I certainly appreciate the due diligence here, but for future reference, the runconfigs in the examples directory are first and foremost intended to be examples. This means that what matters most is the fields conform realistic looking values, but they don't need to be exhaustive or correspond directly with the sample inputs we get with a delivery.
So in this case, having just a handful (say 4 or 5) of input paths listed here would be sufficient for someone to get the idea of how to fill out a "real" runconfig. It also helps prevent the example version from growing to a size that's harder to comprehend.
There was a problem hiding this comment.
I figured that might be the case. I'll prune it down
There was a problem hiding this comment.
Pruned down to 5 entries for each of the 4 input RTC groups and then those 4 sets in the PGE InputFilesGroup to reflect that all the files in the input RTC groups should be in there (as I understand things)
src/opera/pge/cslc_s1/templates/OPERA_ISO_metadata_L2_CSLC_S1_template.xml.jinja2
Show resolved
Hide resolved
src/opera/pge/dist_s1/templates/OPERA_ISO_metadata_L3_DIST_S1_template.xml.jinja2
Show resolved
Hide resolved
src/opera/pge/rtc_s1/templates/OPERA_ISO_metadata_L2_RTC_S1_template.xml.jinja2
Show resolved
Hide resolved
| 'moderate_confidence_threshold': '3.5', | ||
| 'n_lookbacks': '3', | ||
| 'n_workers_for_despeckling': '5', | ||
| 'post_rtc_opera_ids': 'OPERA_L2_RTC-S1_T137-292318-IW1_20250102T015857Z_20250102T190143Z_S1A_30_v1.0,' |
There was a problem hiding this comment.
My comment regarding the example runconfigs also sort of applies here, i.e, no need to be completely faithful to what we might see in production or a "real" test case. Just need something "representative enough" so these canned examples don't grow to be unwieldy and hard to maintain.
There was a problem hiding this comment.
Funnily enough I did. But I guess not enough (so many RTCs!)
There was a problem hiding this comment.
Pruned it down to 5 each like with the example RC
Description
Affected Issues
Testing