Skip to content

Commit

Permalink
remove some comments. #8
Browse files Browse the repository at this point in the history
  • Loading branch information
davemfish committed Feb 9, 2024
1 parent 39286a0 commit 57389e2
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions src/geometamaker/geometamaker.py
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,6 @@ def set_contact(self, organization=None, individualname=None, positionname=None,
for k, v in kwargs.items():
self.mcf['contact'][section][k] = v

# TODO: validate just the contact section instead?
# Not obvious how to do that using the complete schema.
self.validate()

def get_contact(self, section='default'):
Expand Down Expand Up @@ -446,20 +444,10 @@ def set_band_description(self, band_number, name=None, title=None,
attribute['abstract'] = abstract
if units is not None:
attribute['units'] = units
# TODO: I don't like using `type` as the argname,
# but that is the name of the MCF property, and making
# the setter's argnames match makes it convenient to do things
# like mc_a.set_band_description(1, **mc_b.get_band_description(1))
if type is not None:
attribute['type'] = type

self.mcf['content_info']['attributes'][idx] = attribute
# TODO: cannot validate entire MCF here because this setter
# is called as part of the init process before other required MCF
# properties are set. Solutions could be to make create_band_description()
# and create_field_description() methods instead of calling these setters.
# Or figure out how to validate just one section of the MCF.
# self.validate()

def get_band_description(self, band_number):
"""Get the attribute metadata for a band.
Expand Down Expand Up @@ -505,8 +493,6 @@ def set_field_description(self, name, title=None, abstract=None,
attribute['type'] = type

self.mcf['content_info']['attributes'][idx] = attribute
# TODO: see comment in set_band_description
# self.validate()

def get_field_description(self, name):
"""Get the attribute metadata for a field.
Expand Down

0 comments on commit 57389e2

Please sign in to comment.