Minor updates to data models #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, one more thing before this is ready @phargogh |
phargogh
approved these changes
Jan 9, 2025
| @@ -28,7 +28,7 @@ | |||
| 'https', | |||
| ] | |||
|
|
|||
| DT_FMT = '%Y-%m-%d %H:%M:%S' | |||
| DT_FMT = '%Y-%m-%d %H:%M:%S %Z' | |||
Comment on lines
+276
to
+277
| raster_size={'width': info['raster_size'][0], | ||
| 'height': info['raster_size'][1]}) |
There was a problem hiding this comment.
I also like that this could be expanded to include the number of bands or any other attributes that expression the dimensionality of the dataset in the future, should it become necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback, we have a few changes to attributes:
mediatype: removed, not usefulname: removed, not useful, redundant withpathand too easily confused withtitleraster_size: changed fromlisttodictto allow "width" and "height" labelsmetadata_version: changed togeometamaker_versionto be more accurateAll these changes are made backwards-compatible with respect to
describinga dataset with an existingymldocument. When a pre-existing document is loaded, incompatible attributes are removed/replaced with warnings issued.validatewill issueValidationErrorson a document with the old attributes.Fixes #58