Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding type checking for base, target path inputs to warp_raster #422

Conversation

phargogh
Copy link
Member

@phargogh phargogh commented Jan 7, 2025

This PR is a simple fix to #421, where we'd get to a cryptic GDAL error if the developer accidentally provided a source or target path that wasn't a string. In my case, I passed a tuple. Now the function will just raise ValueError with a short but hopefully more helpful error message if the path provided is not a string.

Fixes:#421

Copy link
Contributor

@claire-simpson claire-simpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@claire-simpson claire-simpson merged commit 4814279 into natcap:main Jan 8, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants