More and better benchmarks #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanaelbosch
force-pushed
the
more-benchmarking
branch
from
c428d22 to
31ff926
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 94.39% 94.04% -0.35%
==========================================
Files 36 36
Lines 1535 1512 -23
==========================================
- Hits 1449 1422 -27
- Misses 86 90 +4 ☔ View full report in Codecov by Sentry. |
nathanaelbosch
force-pushed
the
more-benchmarking
branch
from
d1f62ce to
984fb28
Compare
|
1.6 tests don't pass due to an issue with SymbolicUtils: JuliaSymbolics/SymbolicUtils.jl#563 |
nathanaelbosch
commented
Nov 11, 2023
nathanaelbosch
force-pushed
the
more-benchmarking
branch
from
c2e7167 to
e930887
Compare
nathanaelbosch
force-pushed
the
more-benchmarking
branch
4 times, most recently
from
2490273 to
79b413f
Compare
nathanaelbosch
force-pushed
the
more-benchmarking
branch
from
79b413f to
5a2a181
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Current state and open tasks:
WorkPrecisioninstead of just the one passed aserror_estimate? SciML/DiffEqDevTools.jl#125 and this improved plot recipe: More flexible plot recipe SciML/DiffEqDevTools.jl#128. EDIT: These changes are in!chi2, which sometimes throws SingularException. This means I should first hand-check the issues, but then if they seem reasonable, maybe just default to a warning and pseudoinverse. EDIT: This is fixed!