-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kronecker EK0 #243
Merged
Merged
Kronecker EK0 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
commented
Oct 10, 2023
nathanaelbosch
force-pushed
the
kronecker
branch
from
October 27, 2023 12:34
7f8ae51
to
2e95676
Compare
nathanaelbosch
force-pushed
the
kronecker
branch
from
October 27, 2023 12:47
2e95676
to
c414577
Compare
nathanaelbosch
commented
Oct 28, 2023
Simplifying the code will happen after!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the EK0 go brr by implementing covariances in Kronecker form! The paper "Probabilistic ODE Solutions in Millions of Dimensions" explains how.
Things that still need to get fixed as right now parts of the package are still broken
ClassicSolverInit
test/correctness.jl
I had to change many relative tolerance levels (EDIT: Turns out it all came from one single missing transpose somewhere)Afterwards:
Big issue I found while benchmarking: There are huge performance regressions right now, in particular for the EK1. This needs to be thoroughly investigated.
EDIT: The issue seems to be that for some reason, quite often
generic_matmatmul!
is called which, for some reason, allocates arrays.EDIT: Resolved! Runtimes are good, bugs are gone, tests pass. All that's left is some refactoring and clean up and then this is good to go!
EDIT: Left to do:
IsoKroneckerProduct
?CovarianceFactorization
? EtcEDIT: Almost good to go! But this needs more tests. For example: