Refactor the plotting in favor of a Gaussian plot recipe
#291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanaelbosch
changed the title
Gaussian plot recipe
nathanaelbosch
force-pushed
the
refactor/plotrecipe
branch
2 times, most recently
from
87f1321 to
a6f40c8
Compare
nathanaelbosch
commented
Jan 25, 2024
nathanaelbosch
commented
Jan 25, 2024
nathanaelbosch
commented
Jan 25, 2024
nathanaelbosch
commented
Jan 25, 2024
nathanaelbosch
commented
Jan 25, 2024
nathanaelbosch
commented
Jan 25, 2024
Previously we had a recipe for the specific solution type that we implemented. But for some reason, this broke du to sanges of SciML. So to not have such issues again, let's just use their plot recipe! To do this we just needed to implement some recipes for the `Gaussian` type that we use in the solutions, and make sure that the solution interpolation etc is doing what it should do.
Though we might want to add this in this PR!!
nathanaelbosch
force-pushed
the
refactor/plotrecipe
branch
from
903d724 to
b489594
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had a recipe for the specific solution type that we implemented. But for some reason, this broke du to sanges of SciML. So to not have such issues again, let's just use their plot recipe! To do this we just needed to implement some recipes for the
Gaussiantype that we use in the solutions, and make sure that the solution interpolation etc is doing what it should do.This turned out bigger than I thought: To properly use the SciMLBase plot recipe, I should also use the SciMLBase solution interpolation. So doing this is what's left to do for this PR.
EDIT [2024-01-24]: