Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jquery deprecation. #615

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

dogomedia-github
Copy link

This is an updated pull request to fix the jquery ready event deprecation. As more and more deployments are moving to newer Jquery versions, it would be a good idea to fix this once and for all.

I've reviewed all the previous pull requests such as #575, #447, and #379. It looks like all of them had problems but #447 had a proper fix in the notes, only the original contributor never updated the pull request.

I've updated the pull based on the solution in #447 but with the updated events page:load turbolinks:load turbo:load.

@nathanvda
Copy link
Owner

Thank you for your PR and your investigative work (checking all the old PR's).

I had to re-check the #447, I am very glad you did this work. For me it was not a big issue, because I always use turbolinks, but I understand the current code does not work if people are only using jquery and not turbolinks (any version thereof).

@nathanvda nathanvda merged commit 208db1c into nathanvda:master Oct 22, 2021
@rmaspero
Copy link

Am I right in thinking this hasn't been published in the NPM package yet?

@edbarbera
Copy link

Does this change warrant a bump in the version number? Does it change anything for users that don't use turbolinks? e.g. is it backwards compatible? I know it's a quite a while since it was merged, but just wondering as I've been upgrading to JQuery 3 and have had to fix Cocoon to this commit hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants