Add SCSS support #40
Merged
Add SCSS support #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes the Dockerfile isn't currently being used. We're planning on using Github Actions to deploy using zappa. I think the scss files could be built there once we have that setup. |
colinbowen
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SCSS support for CSS files using NodeJS and
sass.Requires application to build CSS before starting with
npm run build. I need some help understanding where to add this command in the application's startup. From what I can tell, theDockerfileisn't ever being used - is that correct?Frontend developers can build and watch styles with
npm run dev.SCSS can be linted and fixed with
npm run lint.