Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https for iiif manifest urls not http #666

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Use https for iiif manifest urls not http #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c5e3bc
Use https for iiif manifest urls not http
anthonyhashemi Nov 25, 2024
2f57a20
Fix iiif manifest tests
anthonyhashemi Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/main/util/render_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def generate_pdf_manifest(record_id):

manifest = {
"@context": [
"http://iiif.io/api/presentation/3/context.json",
"https://iiif.io/api/presentation/3/context.json",
],
"id": f"{url_for('main.generate_manifest', record_id=record_id, _external=True, render=True)}",
"type": "Manifest",
Expand Down Expand Up @@ -173,7 +173,7 @@ def generate_image_manifest(s3_file_object, record_id):
file_url = presigned_url

manifest = {
"@context": "http://iiif.io/api/presentation/2/context.json",
"@context": "https://iiif.io/api/presentation/3/context.json",
"@id": f"{url_for('main.generate_manifest', record_id=record_id, _external=True)}",
"@type": "sc:Manifest",
"label": filename,
Expand Down
4 changes: 2 additions & 2 deletions app/tests/test_routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def test_route_generate_pdf_manifest(
assert response.status_code == 200

expected_pdf_manifest = {
"@context": ["http://iiif.io/api/presentation/3/context.json"],
"@context": ["https://iiif.io/api/presentation/3/context.json"],
"behavior": ["individuals"],
"description": "Manifest for open_file_once_closed.pdf",
"id": f"http://localhost/record/{file.FileId}/manifest?render=True",
Expand Down Expand Up @@ -205,7 +205,7 @@ def test_route_generate_image_manifest(
assert response.status_code == 200

expected_image_manifest = {
"@context": "http://iiif.io/api/presentation/2/context.json",
"@context": "https://iiif.io/api/presentation/3/context.json",
"@id": f"http://localhost/record/{file.FileId}/manifest",
"@type": "sc:Manifest",
"description": f"Manifest for {file.FileName}",
Expand Down
Loading