update e2e tests #710
update e2e tests #710
Conversation
| page.get_by_label("Email address").fill(username) | ||
| page.get_by_label("Password").fill(password) | ||
| page.get_by_role("button", name="Sign in").click() | ||
|
|
||
| # keycloak local | ||
| # page.get_by_label("Username or email").click() |
There was a problem hiding this comment.
can we remove the comments
| print(f"Error creating user: {e}") | ||
| raise # Re-raise the exception to fail the test | ||
|
|
||
| if not user_id: |
There was a problem hiding this comment.
does this block ever get hit if you raise the exception above?
| @@ -24,7 +24,9 @@ def test_search_to_record(aau_user_page: Page): | |||
|
|
|||
| aau_user_page.get_by_role("textbox").first.fill("a") | |||
| aau_user_page.get_by_role("button", name="Search").click() | |||
| expect(aau_user_page).to_have_url("search_results_summary?query=a") | |||
| expect(aau_user_page).to_have_url( | |||
There was a problem hiding this comment.
so this test is the one about nvaigating to a record i na search journey.
I think the tests in class TestSearchResultsSummary: (and possible the other test classes there) in e2e_tests/test_search.py would still be broken though, will those be done in a separate PR?
We just need to make sure that we cover the 2 ac in the ticket: https://national-archives.atlassian.net/jira/software/projects/AYR/boards/66?selectedIssue=AYR-1236&text=AYR-1236
The AC do have 2 actions and currently that file splits out these scenarios into 2 test classes with the second starting from the summary results page, but do whatever feels best to you.
colinbowen
force-pushed
the
AYR-1236/opensearch-e2e-tests
branch
from
5b9ffc7 to
85d32bd
Compare
Changes in this PR
JIRA ticket
Screenshots of UI changes
Before
After