Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDRD-153 - Upgrade terraform and aws provider #308

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

vimleshtna
Copy link
Contributor

No description provided.

Copy link
Contributor

@TomJKing TomJKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

The test are failing though. Getting the following error for the Terraform validate check (https://github.com/nationalarchives/da-reference-generator/actions/runs/11896991487/job/33150193634?pr=308):

│ Error: Unsupported argument
│ 
│   on root_main.tf line 78, in module "reference_generator_api_gateway":
│   78:   api_method_settings = [{
│ 
│ An argument named "api_method_settings" is not expected here.

Copy link
Contributor

@TomJKing TomJKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@vimleshtna vimleshtna merged commit 08f5afd into main Nov 21, 2024
6 checks passed
@vimleshtna vimleshtna deleted the TDRD-153-upgrade-terraform branch November 21, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants