Tdr 3490 update readme #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimleshtna
reviewed
Oct 31, 2023
README.md
Outdated
| @@ -24,6 +24,14 @@ A 500 response body will be returned if any issues occur when calling the Lambda | |||
| * numberofrefs parameter isn't an int | |||
| * any dynamodb Exceptions (key not found, unable to update, etc) | |||
|
|
|||
| The number of references that can be returned in a single call is limited, because: | |||
| * prevent a single call using up all possible reference; | |||
There was a problem hiding this comment.
A minor rewording here, change from all possible reference to all possible references
README.md
Outdated
|
|
||
| Calling clients will need to handle this limit by making multiple calls to retrieve the required number of references if it is greater than the limit. | ||
|
|
||
| The limit is store here for use by calling clients: [reference_generator_limit](https://github.com/nationalarchives/da-terraform-configurations/blob/main/tdr/main.tf) |
There was a problem hiding this comment.
A minor rewording here, change from The limit is store here to The limit is stored here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.