Move installation of formatting and linting tools to Dockerfile (#25)

* Move Poetry and npm installs to Dockerfile rather than dev startup script

* Update deps for dev and don't use the cache directory

* Use nvm during build process

* Use source to load nvm

* Update nvm path

* Ignore SC1091 for shellcheck on Dockerfile

* Update CHANGELOG.md

.github/actions/lint/action.yml

@@ -20,5 +20,5 @@ runs:
       run: |
         cd ${{ inputs.dockerfile-location }}
         [ -d "./bin" ] && shellcheck --external-sources --exclude=SC1091 ./bin/*
-        shellcheck --external-sources --exclude=SC2148 ./Dockerfile
+        shellcheck --external-sources --exclude=SC2148 --exclude=SC1091 ./Dockerfile
       shell: bash

CHANGELOG.md

@@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 ### Changed
+
+- Installation of formatting and linting tools moved to `Dockerfile` so are available at startup of the dev image
+
 ### Deprecated
 ### Removed
 ### Fixed

docker/tna-python-dev/Dockerfile

@@ -45,4 +45,12 @@ ENV PATH="/home/app/.local/bin/tasks:/home/app/.local/bin/dev:$PATH"
 # ==========================================
 COPY --chown=app lib/* /home/app/
 
+# ==========================================
+# Install the tools required for linting and
+# fixing both Python and JS/CSS code
+# ==========================================
+RUN python -m pip install --no-cache-dir --quiet black==24.10.0 flake8==7.1.1 isort==5.13.2; \
+    . "$HOME/.nvm/nvm.sh"; \
+    npm install -g [email protected] [email protected] [email protected] [email protected] [email protected]
+
 CMD ["dev"]

docker/tna-python-dev/bin/dev

@@ -1,9 +1,6 @@
 #!/bin/bash
 
 poetry install --no-root --with dev || true
-python -m pip install --quiet black==24.10.0 flake8==7.1.0 isort==5.13.2
-
-cd /app || return
 
 . "$HOME/.nvm/nvm.sh"
 if [ -f "/app/.nvmrc" ]
@@ -12,7 +9,7 @@ then
 else
   nvm use default
 fi
-npm install -g [email protected] [email protected] [email protected] [email protected] [email protected]
+npm install
 
 if [ -d "/home/app/.local/bin/tasks" ]
 then