Add forgotten tests for helper #380
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonj04
approved these changes
Sep 11, 2023
| def test_xpath_single(): | ||
| node = lxml.etree.fromstring("<root><cat>1</cat><cat>2</cat></root>") | ||
| path = "//cat/text()" | ||
| assert get_xpath_match_string(node, path) == "1" |
There was a problem hiding this comment.
Happy with this PR as stands, note for future that we should probably rename this to get_xpath_first_matching_string or similar, or have this method error out if it has more than one match
anthonyhashemi
approved these changes
Sep 11, 2023
dragon-dxw
force-pushed
the
manifestation-date-access
branch
from
81797b4 to
43aed52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Trello card / Rollbar error (etc)