Provide publication information when getting metadata for search results #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
changed the title
dragon-dxw
changed the title
| assert on_hold_document.status == DOCUMENT_STATUS_HOLD | ||
|
|
||
| published_document = Document("test/1234", mock_api_client) | ||
| published_document.is_held = False | ||
| published_document.is_published = True | ||
| published_document.assigned_to = "duck" |
anthonyhashemi
approved these changes
Sep 18, 2023
anthonyhashemi
approved these changes
Sep 18, 2023
dragon-dxw
force-pushed
the
FCL-82-consistent-status
branch
from
3e90a83 to
08fec9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is potentially breaking behaviour since there is a new
publishedvalue editor_status can emit ornewfor Document.status.https://linear.app/tna/issue/FCL-82/status-in-search-results-doesnt-match-the-actual-status-of-the
But it turns out that the editor just displays this value, never really parsing it; seems to be true for the Document too.
Editor could do with a colour tweak for "new"