Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated xml_tools module #664

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

jacksonj04
Copy link
Collaborator

Summary of changes

This has been deprecated for a while now; remove xml_tools entirely from the client

Checklist

  • I have created/updated method docstrings (if necessary)
  • I have considered if this is a breaking change
  • I have updated the changelog (if necessary)

@jacksonj04 jacksonj04 requested a review from dragon-dxw August 29, 2024 15:40
@jacksonj04 jacksonj04 force-pushed the FCL-269-deprecate-xml-tools-in-api-client branch from b6112b0 to 46d7be2 Compare August 29, 2024 16:08
@dragon-dxw
Copy link
Collaborator

We don't appear to be importing xml_tools anywhere.

@dragon-dxw dragon-dxw force-pushed the FCL-269-deprecate-xml-tools-in-api-client branch from 46d7be2 to 066fff1 Compare September 5, 2024 16:44
@jacksonj04 jacksonj04 force-pushed the FCL-269-deprecate-xml-tools-in-api-client branch from 066fff1 to 399496b Compare September 10, 2024 10:07
This has been deprecated for a while now; remove xml_tools entirely from the client

BREAKING CHANGE:

Remove the `xml_tools` module
@jacksonj04 jacksonj04 force-pushed the FCL-269-deprecate-xml-tools-in-api-client branch from 399496b to 3eb5f9d Compare September 10, 2024 10:13
@jacksonj04 jacksonj04 added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit 4944026 Sep 10, 2024
12 of 13 checks passed
@jacksonj04 jacksonj04 deleted the FCL-269-deprecate-xml-tools-in-api-client branch September 10, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants