-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FCL-309] Add the ability for documents to store abstract identifiers in MarkLogic properties #778
Merged
jacksonj04
merged 7 commits into
main
from
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
Dec 3, 2024
Merged
[FCL-309] Add the ability for documents to store abstract identifiers in MarkLogic properties #778
jacksonj04
merged 7 commits into
main
from
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonj04
force-pushed
the
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
branch
6 times, most recently
from
November 19, 2024 19:00
e70ea20
to
9611d5a
Compare
jacksonj04
force-pushed
the
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
branch
from
November 25, 2024 13:01
d931400
to
6d49bb0
Compare
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
dragon-dxw
reviewed
Nov 26, 2024
I'm a touch concerned about the properties being used because they might be stale if overwritten, but that's a risk anyway at the moment. Do we want more general properties parsing and editing? (Probably not) |
jacksonj04
force-pushed
the
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
branch
5 times, most recently
from
November 29, 2024 11:06
63c0ad6
to
090f194
Compare
dragon-dxw
force-pushed
the
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
branch
2 times, most recently
from
November 29, 2024 18:17
caef3e7
to
b326df2
Compare
jacksonj04
force-pushed
the
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
branch
from
November 29, 2024 19:02
b326df2
to
2d5a816
Compare
…l Citation schema In this framework both the schema defining an identifier and the identifiers themselves are implemented as abstract classes. This is because we know that some types of identifier (such as Neutral Citations) may have places in the codebase where we require additional type-specific functionality. By using type-specific concretions of those abstract classes we can guarantee we're doing so in a type-safe manner, whilst still keeping a generic framework for the underlying storage.
…entations of identifiers
This is necessary for our identifier to document mapping table, which speeds up retrieval of a document for any given identifier scheme.
This helps us identify the type of thing we're looking at if the context isn't clear during debugging operations
jacksonj04
force-pushed
the
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
branch
from
December 2, 2024 14:48
2d5a816
to
deb72ae
Compare
dragon-dxw
approved these changes
Dec 3, 2024
jacksonj04
deleted the
FCL-309-implement-framework-for-storing-multiple-identifiers-against-documents
branch
December 3, 2024 10:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
IdentifierSchema
andIdentifier
abstract classes which define interfaces for how we think about what any given type of identifier looks like (IdentifierSchema
), and how we might be able to interact with specific instances of that identifier (Identifier
)NeutralCitationSchema
andNeutralCitation
concretions of the above abstract classes, defining NCN-specific implementations of methods where necessary.Identifier
s can compile themselves down to a URL slug, used for simplifying retrieval at any given URL.Document
which allow CRUD operations on its identifiers, using the above classes to turn identifier concepts into serialisations which can be stashed in the MarkLogic properties for a document.Checklist
Jira
FCL-309