Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use save_identifiers on document not identifiers.save() #801

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

dragon-dxw
Copy link
Collaborator

Summary of changes

Move saving identifiers to the document

Copy link
Collaborator

@jacksonj04 jacksonj04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a lot more solid to me!

@dragon-dxw
Copy link
Collaborator Author

dragon-dxw commented Dec 10, 2024

Add a test --
given a particular Document with a known value of Identifiers (probably mock this out tbh)
when I call document.save_identifiers() it
calls identifiers.validate and
calls set_property_as_node with expected values (edited)

@dragon-dxw dragon-dxw force-pushed the FCL-496-save-identifier-on-document branch from 3a049cf to 94cf9ee Compare December 12, 2024 11:17
@dragon-dxw dragon-dxw enabled auto-merge December 12, 2024 11:18
@dragon-dxw dragon-dxw added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit bca1e2a Dec 12, 2024
12 of 14 checks passed
@dragon-dxw dragon-dxw deleted the FCL-496-save-identifier-on-document branch December 12, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants