Skip to content

Commit

Permalink
Merge pull request #388 from nationalarchives/fix/no-import-mypy-boto
Browse files Browse the repository at this point in the history
Only import mypy boto3 if typechecking
  • Loading branch information
dragon-dxw authored Jan 5, 2024
2 parents 9fa7c75 + be387d0 commit eeeaf2a
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 5 deletions.
5 changes: 4 additions & 1 deletion src/lambdas/determine_replacements_abbreviations/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,21 @@

import json
import logging
from typing import TYPE_CHECKING

import boto3
import spacy
from aws_lambda_powertools.utilities.data_classes import SQSEvent, event_source
from aws_lambda_powertools.utilities.data_classes.sqs_event import SQSRecord
from aws_lambda_powertools.utilities.typing import LambdaContext
from mypy_boto3_sqs.type_defs import MessageAttributeValueQueueTypeDef

from abbreviation_extraction.abbreviations_matcher import abb, abb_pipeline
from utils.environment_helpers import validate_env_variable
from utils.types import DocumentAsXMLString, NLPModel, Replacement

if TYPE_CHECKING:
from mypy_boto3_sqs.type_defs import MessageAttributeValueQueueTypeDef

LOGGER = logging.getLogger()
LOGGER.setLevel(logging.INFO)

Expand Down
8 changes: 6 additions & 2 deletions src/lambdas/determine_replacements_caselaw/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,23 @@
import json
import logging
import urllib.parse
from typing import TYPE_CHECKING

import boto3
import spacy
from aws_lambda_powertools.utilities.data_classes import S3Event, event_source
from aws_lambda_powertools.utilities.data_classes.s3_event import S3EventRecord
from aws_lambda_powertools.utilities.typing import LambdaContext
from mypy_boto3_sqs.type_defs import MessageAttributeValueQueueTypeDef

from database import db_connection
from utils.environment_helpers import validate_env_variable
from utils.initialise_db import init_db_connection
from utils.types import DocumentAsXMLString

from ..database import db_connection

if TYPE_CHECKING:
from mypy_boto3_sqs.type_defs import MessageAttributeValueQueueTypeDef

LOGGER = logging.getLogger()
LOGGER.setLevel(logging.INFO)

Expand Down
5 changes: 4 additions & 1 deletion src/lambdas/determine_replacements_legislation/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,22 @@

import json
import logging
from typing import TYPE_CHECKING

import boto3
import spacy
from aws_lambda_powertools.utilities.data_classes import SQSEvent, event_source
from aws_lambda_powertools.utilities.data_classes.sqs_event import SQSRecord
from aws_lambda_powertools.utilities.typing import LambdaContext
from mypy_boto3_sqs.type_defs import MessageAttributeValueQueueTypeDef

from database import db_connection
from utils.environment_helpers import validate_env_variable
from utils.initialise_db import init_db_connection
from utils.types import DocumentAsXMLString, NLPModel

if TYPE_CHECKING:
from mypy_boto3_sqs.type_defs import MessageAttributeValueQueueTypeDef

LOGGER = logging.getLogger()
LOGGER.setLevel(logging.INFO)

Expand Down
6 changes: 5 additions & 1 deletion src/lambdas/xml_validate/index.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,21 @@
import logging
import urllib.parse
from io import BytesIO
from typing import TYPE_CHECKING

import boto3
from aws_lambda_powertools.utilities.data_classes import S3Event, event_source
from aws_lambda_powertools.utilities.data_classes.s3_event import S3EventRecord
from aws_lambda_powertools.utilities.typing import LambdaContext
from lxml import etree
from mypy_boto3_sqs.type_defs import MessageAttributeValueQueueTypeDef

from utils.environment_helpers import validate_env_variable
from utils.types import DocumentAsXMLBytes

if TYPE_CHECKING:
from mypy_boto3_sqs.type_defs import MessageAttributeValueQueueTypeDef


LOGGER = logging.getLogger()
LOGGER.setLevel(logging.INFO)

Expand Down

0 comments on commit eeeaf2a

Please sign in to comment.