Request lock release whilst sending XML to marklogic #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
commented
Apr 10, 2024
| @@ -110,9 +111,6 @@ def process_event(sqs_rec: SQSRecord) -> None: | |||
| api_endpoint, judgment_uri, file_content, API_USERNAME, API_PASSWORD | |||
| ) | |||
|
|
|||
| # release the lock | |||
| release_lock(api_endpoint, judgment_uri, API_USERNAME, API_PASSWORD) | |||
|
|
|||
There was a problem hiding this comment.
This is no longer needed because the lock will be released as a part of patching the file.
CristinaRO
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Good work! We'll let you do the merging in the needed order, but the other PR is also approved nationalarchives/ds-caselaw-privileged-api#303.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits from the updated version of the privileged API to ensure that the document is always unlocked after use -- will break unlocking if that other one hasn't been merged.
https://github.com/nationalarchives/ds-caselaw-privileged-api/pulls