Merge pull request #29 from nationalarchives/handle-null-uri-in-json

Handle case where URI is null in the JSON file
nationalarchives · May 5, 2022 · 2d1dbac · 2d1dbac
2 parents ff3ec6c + 4141571
commit 2d1dbac
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ds-caselaw-ingester/lambda_function.py b/ds-caselaw-ingester/lambda_function.py
@@ -37,12 +37,12 @@ class MaximumRetriesExceededException(Exception):
 
 
 def extract_uri(metadata: dict, consignment_reference: str) -> str:
-    uri = metadata["parameters"]["PARSER"].get("uri", "").replace('https://caselaw.nationalarchives.gov.uk/id/', '')
+    uri = metadata["parameters"]["PARSER"].get("uri", "")
 
     if not uri:
         uri = f'failures/{consignment_reference}'
 
-    return uri
+    return uri.replace('https://caselaw.nationalarchives.gov.uk/id/', '')
 
 
 def extract_docx_filename(metadata: dict) -> str: