Crash if NOTIFY_API_KEY not set and email is attempted to be sent

nationalarchives · Jun 5, 2024 · da729a4 · da729a4
1 parent 7918bdc
commit da729a4
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/ds-caselaw-ingester/lambda_function.py b/ds-caselaw-ingester/lambda_function.py
@@ -461,7 +461,7 @@ def send_updated_judgment_notification(self) -> None:
             )
             return
 
-        notifications_client = NotificationsAPIClient(os.getenv("NOTIFY_API_KEY"))
+        notifications_client = NotificationsAPIClient(os.environ["NOTIFY_API_KEY"])
         response = notifications_client.send_email_notification(
             email_address=os.getenv("NOTIFY_EDITORIAL_ADDRESS"),
             template_id=os.getenv("NOTIFY_UPDATED_JUDGMENT_TEMPLATE_ID"),
@@ -485,7 +485,7 @@ def send_new_judgment_notification(self) -> None:
                 f"Would send a notification but we're not in production.\n{personalisation}"
             )
             return
-        notifications_client = NotificationsAPIClient(os.getenv("NOTIFY_API_KEY"))
+        notifications_client = NotificationsAPIClient(os.environ["NOTIFY_API_KEY"])
         response = notifications_client.send_email_notification(
             email_address=os.getenv("NOTIFY_EDITORIAL_ADDRESS"),
             template_id=os.getenv("NOTIFY_NEW_JUDGMENT_TEMPLATE_ID"),