Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich annotations for new versions #103

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

jacksonj04
Copy link
Collaborator

Using the new richer VersionAnnotations in v17 of the API client, populate them with richer information about what has happened up to the point of ingestion.

@jacksonj04 jacksonj04 force-pushed the feature/annotate-version-on-ingestion branch 2 times, most recently from be48692 to 6d35f93 Compare October 16, 2023 12:08
@jacksonj04 jacksonj04 requested a review from dragon-dxw October 16, 2023 12:09
@jacksonj04 jacksonj04 marked this pull request as ready for review October 16, 2023 12:09
Copy link
Collaborator

@dragon-dxw dragon-dxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't guarantee TDR metadata exists because it may not have originated from TDR.

@jacksonj04 jacksonj04 force-pushed the feature/annotate-version-on-ingestion branch 2 times, most recently from 038ec75 to 91ee1a7 Compare October 17, 2023 13:10
@jacksonj04 jacksonj04 requested a review from dragon-dxw October 17, 2023 13:11
Copy link
Collaborator

@dragon-dxw dragon-dxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test -- please review before merge!

@dragon-dxw dragon-dxw force-pushed the feature/annotate-version-on-ingestion branch from 60b0964 to 422cce9 Compare October 18, 2023 13:30
@jacksonj04 jacksonj04 merged commit 08703b2 into main Oct 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants