Define environment variables and timeout in code #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonj04
force-pushed
the
fix/env-variables-are-set-properly-on-deploy
branch
from
0a05122 to
83a49ae
Compare
jacksonj04
force-pushed
the
fix/env-variables-are-set-properly-on-deploy
branch
from
83a49ae to
dd33c27
Compare
dragon-dxw
changed the title
|
Currently suffering from a 3s timeout -- not ready for deploy to live. |
dragon-dxw
approved these changes
Oct 16, 2023
dragon-dxw
changed the title
Previously we didn't define any environment variables at deploy time; instead we set them manually. A configuration change when we moved from Python 3.9 to 3.11 caused SAM to redefine the infrastructure, and this in turn caused a all existing environment variables to be wiped, bringing down the staging ingester. This PR moves to defining the environment variables in the `template.yml` file which is used by SAM. The exact values are passed in at deploy time by GitHub Actions as part of configuring the infrastructure. Variables are stored in GitHub environments.
jacksonj04
force-pushed
the
fix/env-variables-are-set-properly-on-deploy
branch
from
dd33c27 to
2409e83
Compare
The default is three seconds, which isn't enough time for tasks to complete.
jacksonj04
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we didn't define any environment variables at deploy time; instead we set them manually. A configuration change when we moved from Python 3.9 to 3.11 caused SAM to redefine the infrastructure, and this in turn caused a all existing environment variables to be wiped, bringing down the staging ingester.
This PR moves to defining the environment variables in the
template.ymlfile which is used by SAM. The exact values are passed in at deploy time by GitHub Actions as part of configuring the infrastructure.Variables are stored in GitHub environments.