Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does changing the python version break stuff? #113

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.10"
cache: pip
cache-dependency-path: |
requirements/base.txt
Expand All @@ -29,9 +29,9 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@main
- name: Set up Python 3.11
- name: Set up Python 3.10
uses: actions/setup-python@v4
with:
python-version: "3.11"
python-version: "3.10"
- run: pip install -r requirements/local.txt
- run: python -m pytest ds-caselaw-ingester/tests.py
2 changes: 0 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ name: Deploy lambda to AWS

on:
push:
branches:
- main

jobs:
build-deploy:
Expand Down
2 changes: 1 addition & 1 deletion .python-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.11
3.10
2 changes: 1 addition & 1 deletion scripts/setup-localstack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ awslocal lambda create-function \
--function-name te-lambda \
--zip-file fileb://dist/lambda.zip \
--handler ds-caselaw-ingester/lambda_function.handler \
--runtime python3.11 \
--runtime python3.10 \
--environment "Variables={MARKLOGIC_HOST=$MARKLOGIC_HOST,MARKLOGIC_USER=$MARKLOGIC_USER,MARKLOGIC_PASSWORD=$MARKLOGIC_PASSWORD,AWS_BUCKET_NAME=$AWS_BUCKET_NAME,AWS_SECRET_KEY=$AWS_SECRET_KEY,AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID,AWS_ENDPOINT_URL=$AWS_ENDPOINT_URL,SQS_QUEUE_URL=$SQS_QUEUE_URL,ROLLBAR_TOKEN=$ROLLBAR_TOKEN,ROLLBAR_ENV=$ROLLBAR_ENV,NOTIFY_API_KEY=$NOTIFY_API_KEY,NOTIFY_EDITORIAL_ADDRESS=$NOTIFY_EDITORIAL_ADDRESS,NOTIFY_NEW_JUDGMENT_TEMPLATE_ID=$NOTIFY_NEW_JUDGMENT_TEMPLATE_ID,EDITORIAL_UI_BASE_URL=$EDITORIAL_UI_BASE_URL,PUBLIC_ASSET_BUCKET=$PUBLIC_ASSET_BUCKET}" \
--role arn:aws:iam::000000000000:role/lambda-role \

Expand Down
16 changes: 8 additions & 8 deletions template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Resources:
Properties:
CodeUri: ds-caselaw-ingester/
Handler: lambda_function.handler
Runtime: python3.11
Runtime: python3.10
Architectures:
- x86_64
Timeout: 420
Expand All @@ -92,13 +92,13 @@ Resources:
ROLLBAR_ENV: !Ref RollbarEnv
ROLLBAR_TOKEN: !Ref RollbarToken
SQS_QUEUE_URL: !Ref SqsQueueUrl
VpcConfig:
SubnetIds:
- !Ref VpcSubnetId0
- !Ref VpcSubnetId1
- !Ref VpcSubnetId2
SecurityGroupIds:
- !Ref VpcSecurityGroupId
VpcConfig:
SubnetIds:
- !Ref VpcSubnetId0
- !Ref VpcSubnetId1
- !Ref VpcSubnetId2
SecurityGroupIds:
- !Ref VpcSecurityGroupId

Outputs:
# ServerlessRestApi is an implicit API created out of Events key under Serverless::Function
Expand Down