Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 support to ingester to be able to ingest the backlog #121

Merged
merged 10 commits into from
Nov 3, 2023

Conversation

dragon-dxw
Copy link
Collaborator

@dragon-dxw dragon-dxw commented Nov 1, 2023

To support the ingestion of backlog documents, we'll have an S3 bucket with an SNS notification pointed at the ingester, so we need to understand those slightly-differently structured SNS messages. A slight wrinkle is that the initial message won't contain a consignment reference, so we'll have to dig that out of the tar.gz json metadata.

Features:

  • support S3 SNS messages
  • smoketest framework for localstack
  • auto publish functionality

@dragon-dxw dragon-dxw force-pushed the ingest-backlog branch 2 times, most recently from a9bb7e2 to 6e4ba62 Compare November 2, 2023 12:17
Copy link
Contributor

@anthonyhashemi anthonyhashemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoken through PR comments on call. Looks good to me. Approving assuming tests added for the new autopublish logic

@dragon-dxw dragon-dxw merged commit daa236e into main Nov 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants