-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S3 support to ingester to be able to ingest the backlog #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
force-pushed
the
ingest-backlog
branch
2 times, most recently
from
November 2, 2023 12:17
a9bb7e2
to
6e4ba62
Compare
anthonyhashemi
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoken through PR comments on call. Looks good to me. Approving assuming tests added for the new autopublish logic
dragon-dxw
force-pushed
the
ingest-backlog
branch
from
November 3, 2023 12:29
6e4ba62
to
f98986e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the ingestion of backlog documents, we'll have an S3 bucket with an SNS notification pointed at the ingester, so we need to understand those slightly-differently structured SNS messages. A slight wrinkle is that the initial message won't contain a consignment reference, so we'll have to dig that out of the tar.gz json metadata.
Features: