[FCL-176] Tooling configuration audit #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-commit gives us a set of high-level hooks which rapidly sense-check aspects of the repository. This commit adds new ones for preventing the addition of large files, checking for filename casing conflicts, preventing committing of files with open merge conflicts, checking XML validity, preventing the addition of submodules, warning when files have mixed line endings, and accidentally committing to `main`. It also reorders this list for clarity.
jacksonj04
force-pushed
the
FCL-176-pre-commit-audit
branch
from
684664d to
2953b70
Compare
dragon-dxw
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of commits which together make all of FCL's repositories behave more consistently with regard to tooling.
Jira
FCL-176
What?
.pre-commit-config.yamldoes not exclude directories which don't exist, doesn't set default hooks where they aren't needed, and doesn't specify auto-update behaviourpre-commit-hooksrepo includes the new, broader set of recommended checksdetect-secretsis removed (deprecated in favour of GitHub's more comprehensive approach)