Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign documents a UUID on ingestion instead of using NCN-based URI #236

Conversation

jacksonj04
Copy link
Collaborator

Since not all documents will include an NCN, we cannot use NCN-based URIs for them. Instead, assign all new documents a UUID so they can be identified without any semantic meaning, and push the job of providing semantic identifiers to the identifier framework.

@jacksonj04 jacksonj04 force-pushed the FCL-485-pdf-only-mvp-modify-ingester-to-understand-pdf-only-imports branch 3 times, most recently from ffe92c8 to 3ffbbbc Compare December 18, 2024 17:40
@jacksonj04 jacksonj04 changed the title Assign documents a UUID on ingestion instead of using NCN-based URI. Assign documents a UUID on ingestion instead of using NCN-based URI Dec 18, 2024
@jacksonj04 jacksonj04 force-pushed the FCL-485-pdf-only-mvp-modify-ingester-to-understand-pdf-only-imports branch 5 times, most recently from 96a1a74 to 1db1e22 Compare December 19, 2024 12:37
@jacksonj04 jacksonj04 requested a review from jlhdxw December 19, 2024 13:38
Copy link
Collaborator

@jlhdxw jlhdxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacksonj04 jacksonj04 force-pushed the FCL-485-pdf-only-mvp-modify-ingester-to-understand-pdf-only-imports branch from 01f7e6c to d8e8422 Compare December 19, 2024 14:05
@jacksonj04 jacksonj04 marked this pull request as ready for review December 19, 2024 14:18
@jacksonj04 jacksonj04 merged commit a142a87 into main Dec 19, 2024
6 checks passed
@jacksonj04 jacksonj04 deleted the FCL-485-pdf-only-mvp-modify-ingester-to-understand-pdf-only-imports branch December 19, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants