Add NCNs for press summaries and logging of empty citations #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
force-pushed
the
ncns-for-press-summaries
branch
from
3f952fb to
cde27fb
Compare
jacksonj04
approved these changes
Jan 14, 2025
dragon-dxw
force-pushed
the
ncns-for-press-summaries
branch
from
8681577 to
1d17f09
Compare
|
Running against prod now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Press Summaries weren't resolving because the neutral citation is in a different place; extracting the NCN from //uk:summaryOfCite as a fallback.
It's not clear that this is the right answer, since two things will resolve for a press-summaried judgment.
This is already on staging, but should be run on prod if merged.