Swap to using Ruff instead of Flake8 #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonj04
force-pushed
the
chore/use-ruff
branch
2 times, most recently
from
da363bc to
776bb59
Compare
dragon-dxw
approved these changes
Nov 9, 2023
This was creating the singleton at each method's definition time, which worked as designed, but more by good luck than by design. This now explicitly initialises the security model once and passes it to each method as a default argument.
jacksonj04
force-pushed
the
chore/use-ruff
branch
from
3d7988f to
6ceb781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our preference is to use Ruff as our one-stop linting tool. This adds ruff to pre-commit in place of Flake8, and fixes (or selectively chooses to ignore) things that it surfaces.