Resolve base page #1679
Draft
Resolve base page #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
force-pushed
the
FCL-496-8-resolve-identifier-urls
branch
from
f143f79 to
7613137
Compare
dragon-dxw
force-pushed
the
FCL-496-8-resolve-identifier-urls
branch
5 times, most recently
from
4a55d79 to
92dfac8
Compare
There are a number of places where we use formatted_document_uri to get the name of a resource -- images, PDFs and XML spring to mind. But there's now a distinction between these resources. Those at `assets` will share the name of the MarkLogic resource, but those at `/data.extension` will share the name of the loaded page. Changing it only here seems correct.
…can't work with document resolution like this
dragon-dxw
force-pushed
the
FCL-496-8-resolve-identifier-urls
branch
from
9f7c882 to
93f0553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://assets.caselaw.nationalarchives.gov.uk/[ml]/[ml].pdf -- this seems right
https://assets.caselaw.nationalarchives.gov.uk/[ml]/sample1.png -- this seems fine.
http://localhost:3000/[ml]/data.xml -- this is wrong, that should be [id], as it's resolver based link FIXED
Important commit message
There are a number of places where we use formatted_document_uri to get the name of a resource -- images, PDFs and XML spring to mind.
But there's now a distinction between these resources. Those at
assetswill share the name of the MarkLogic resource, butthose at
/data.extensionwill share the name of the loaded page.Changing it only here seems correct.
Changes in this PR:
Jira card / Rollbar error (etc)
Screenshots of UI changes:
Before
After