Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify pypi-publish to match tag #151

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Modify pypi-publish to match tag #151

merged 1 commit into from
Jul 18, 2024

Conversation

dragon-dxw
Copy link
Collaborator

@dragon-dxw dragon-dxw commented Jul 16, 2024

Very speculative, I'm afraid, not sure if this'll work. History below.

@dragon-dxw
Copy link
Collaborator Author

dragon-dxw commented Jul 17, 2024

Nick: hmm, how has this worked in the past…

Previously it was main and there were warnings that we should upgrade to release/v1 but you (very reasonably) said that it'd make sense to track the explicit latest so it was dependabot controlled. I think I broke it whilst changing it to the very reasonable but apparently wrong release/v1.9 and we probably didn't catch that that broken the deploy until now (because it was in this deploy.
So "we hadn't fiddled with it in the past" is the short answer.
Pin pypi-publish to v1 by @dragon-dxw in #138
https://github.com/nationalarchives/ds-caselaw-utils/releases/tag/v1.5.2

Copy link
Collaborator

@jlhdxw jlhdxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dragon-dxw dragon-dxw added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 44aa307 Jul 18, 2024
6 checks passed
@dragon-dxw dragon-dxw deleted the pypi-publish branch July 18, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants