-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FCL-343] Add typing to utils #185
Merged
jacksonj04
merged 11 commits into
main
from
FCL-343-add-typing-and-type-checking-to-utils
Sep 30, 2024
Merged
[FCL-343] Add typing to utils #185
jacksonj04
merged 11 commits into
main
from
FCL-343-add-typing-and-type-checking-to-utils
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy will now run typing checks as part of pre-commit, forcing us to write code which fully expresses its typing
This indicates to downstream consumers of the package that it can be considered as being typed.
jacksonj04
force-pushed
the
FCL-343-add-typing-and-type-checking-to-utils
branch
2 times, most recently
from
September 26, 2024 14:11
30765e5
to
178e206
Compare
dragon-dxw
force-pushed
the
FCL-343-add-typing-and-type-checking-to-utils
branch
from
September 27, 2024 10:58
901b578
to
01d7f25
Compare
dragon-dxw
force-pushed
the
FCL-343-add-typing-and-type-checking-to-utils
branch
from
September 27, 2024 11:07
01d7f25
to
e60ee73
Compare
API client passes tests and typechecks correctly with these changes. |
dragon-dxw
force-pushed
the
FCL-343-add-typing-and-type-checking-to-utils
branch
2 times, most recently
from
September 27, 2024 12:27
c5c653c
to
8676105
Compare
jacksonj04
commented
Sep 27, 2024
dragon-dxw
force-pushed
the
FCL-343-add-typing-and-type-checking-to-utils
branch
from
September 27, 2024 12:47
8676105
to
9b550e6
Compare
dragon-dxw
approved these changes
Sep 27, 2024
dragon-dxw
force-pushed
the
FCL-343-add-typing-and-type-checking-to-utils
branch
from
September 27, 2024 14:58
ed283c2
to
2d06b76
Compare
jacksonj04
deleted the
FCL-343-add-typing-and-type-checking-to-utils
branch
September 30, 2024 10:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer our code to be typed, as it reduces opportunities for misunderstanding.
Enforce typing in utilities, and add missing typing where needed.