Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCL-343] Add typing to utils #185

Merged
merged 11 commits into from
Sep 30, 2024

Conversation

jacksonj04
Copy link
Collaborator

We prefer our code to be typed, as it reduces opportunities for misunderstanding.

Enforce typing in utilities, and add missing typing where needed.

mypy will now run typing checks as part of pre-commit, forcing us to write code which fully expresses its typing
This indicates to downstream consumers of the package that it can be considered as being typed.
@jacksonj04 jacksonj04 force-pushed the FCL-343-add-typing-and-type-checking-to-utils branch 2 times, most recently from 30765e5 to 178e206 Compare September 26, 2024 14:11
@dragon-dxw dragon-dxw force-pushed the FCL-343-add-typing-and-type-checking-to-utils branch from 901b578 to 01d7f25 Compare September 27, 2024 10:58
@dragon-dxw dragon-dxw force-pushed the FCL-343-add-typing-and-type-checking-to-utils branch from 01d7f25 to e60ee73 Compare September 27, 2024 11:07
@dragon-dxw
Copy link
Collaborator

API client passes tests and typechecks correctly with these changes.

@dragon-dxw dragon-dxw force-pushed the FCL-343-add-typing-and-type-checking-to-utils branch 2 times, most recently from c5c653c to 8676105 Compare September 27, 2024 12:27
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
jsonschema-gentypes.yaml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/ds_caselaw_utils/courts.py Show resolved Hide resolved
src/ds_caselaw_utils/courts.py Outdated Show resolved Hide resolved
@dragon-dxw dragon-dxw force-pushed the FCL-343-add-typing-and-type-checking-to-utils branch from 8676105 to 9b550e6 Compare September 27, 2024 12:47
@dragon-dxw dragon-dxw force-pushed the FCL-343-add-typing-and-type-checking-to-utils branch from ed283c2 to 2d06b76 Compare September 27, 2024 14:58
@jacksonj04 jacksonj04 added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit d6eb5c8 Sep 30, 2024
6 checks passed
@jacksonj04 jacksonj04 deleted the FCL-343-add-typing-and-type-checking-to-utils branch September 30, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants