Fix some data issues

nationalarchives · Jan 15, 2024 · 31adaa9 · 31adaa9
1 parent 8829fe6
commit 31adaa9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/sources/rosetta/api.py b/app/sources/rosetta/api.py
@@ -116,7 +116,7 @@ def parse_results(self, raw_results, source_url):
                 record = RecordCreatorPerson(parsed_data.id())
                 record.name = parsed_data.name()
                 record.name_parts = parsed_data.names()
-                record.date = parsed_data.lifespan()
+                record.date = parsed_data.date()
                 record.gender = parsed_data.gender()
                 record.identifier = parsed_data.identifier()
                 record.functions = parsed_data.functions()

diff --git a/app/sources/rosetta/lib/response_parser.py b/app/sources/rosetta/lib/response_parser.py
@@ -73,7 +73,7 @@ def name(self) -> str:
         names = self.names()
         if "name" in names:
             return names["name"]
-        return ""
+        return self.title() or ""
 
     def names(self) -> dict:
         names = {}
@@ -250,7 +250,9 @@ def contact_info(self) -> dict:
             ):
                 document = PyQuery(ephemera)
                 return {
-                    "address_line_1": document("addressline1").text(),
+                    "address_line_1": document("addressline1")
+                    .text()
+                    .replace("<br /><br />", ", "),
                     "town": document("addresstown").text(),
                     "postcode": document("postcode").text(),
                     "country": document("addresscountry").text(),