-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDEV-6 - Remove dev and move commands into root web #1374
Conversation
… chore/root-docker
… chore/root-docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi AJ,
I'm still getting the permissions error when running format - is there a way that you can run sudo chown -R user:user .
after the format commands are run? That'd give the permissions back to the user we're currently on (not sure how to directly get the user though, but I've been running sudo chown -R james:james .
) Only issue is this would need to be run outside the container, I think.
I'm also not getting images load after running fab pull-staging-media
, I see them in the ds-wagtail-media volume but just getting blank images on the FE.
It looks like the management commands are getting run inside the container only as well, so if I do, for example, manage startapp appname
, it creates the new app folder inside the container's folders but doesn't get replicated on my local machine so I can't see/edit the files
… chore/root-docker
WARN[0000] The "UID" variable is not set. Defaulting to a blank string.
WARN[0000] The "GID" variable is not set. Defaulting to a blank string.
time="2023-11-07T15:15:19Z" level=warning msg="The \"UID\" variable is not set. Defaulting to a blank string."
time="2023-11-07T15:15:19Z" level=warning msg="The \"GID\" variable is not set. Defaulting to a blank string." I think the |
… chore/root-docker
Just tested this again in WSL and on normal Windows and I'm getting this error on both
|
On Linux (WSL): I've just tried this again to see what outcome we get, the Django commands are still getting run as e.g. On Windows: Everything is working as expected! I'm happy to swap back to Windows if it means this works, but I think Ian might want to stay on Linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I have set my WSL user to root
, I can now use this perfectly 👌 Same for Windows, that works without any changes needed. Happy to approve this now, but we will need to sort out the other Windows (WSL) dev laptops as well 😃
@ahosgood before merging could you run the formatters here please? I'm getting some test errors when using this |
Replaced with #1743 |
https://national-archives.atlassian.net/browse/EDEV-6
dev
Docker containertna-docker-django
image;tna-docker-django-root
which has the user set toroot
fab dev
followed by things likedev-css
- hopefully really similar to how they are nowroot
during development means we can write changes back to the file system such as theformat
command without the changes being owned by the container useradmin
is created on boot with the passwordadmin
which should speed up developmentisort
,black
andflake8